Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO8601 support for convertDateTime. #2341

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

devinrsmith
Copy link
Member

Fixes #2340

@devinrsmith devinrsmith added this to the Apr 2022 milestone Apr 26, 2022
@devinrsmith devinrsmith self-assigned this Apr 26, 2022
@devinrsmith devinrsmith requested a review from rcaudy April 26, 2022 18:08
rcaudy
rcaudy previously approved these changes Apr 26, 2022
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this change.

@jmao-denver
Copy link
Contributor

should we have a new Python test case for the new format?

@devinrsmith
Copy link
Member Author

should we have a new Python test case for the new format?

We got a java side test. I don't see too much value in replicating in python - we've already validated that to_datetime passes through appropriately.

@devinrsmith devinrsmith merged commit 75fdb2a into deephaven:main Apr 27, 2022
@devinrsmith devinrsmith deleted the iso-8601-convert-date-time branch April 27, 2022 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ISO8601 via convertDateTime
4 participants