-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup python deephaven package dependencies #2538
Cleanup python deephaven package dependencies #2538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Potentially we should just delete WorkerPythonEnvironment, PickledResult, and python-engine-test. None of it is run, see #734 |
I've gone ahead with the further cleanup here. |
...n-engine-test/src/test/java/io/deephaven/engine/table/impl/select/PythonMatchFilterTest.java
Outdated
Show resolved
Hide resolved
python-engine-test/src/test/java/io/deephaven/engine/table/impl/select/TestConditionFilter.java
Outdated
Show resolved
Hide resolved
python-engine-test/src/test/java/io/deephaven/engine/util/TestWorkerPythonEnvironment.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/PickledResult.java
Outdated
Show resolved
Hide resolved
…ython-dependencies
c0b8b22
to
ad46a93
Compare
I've removed the file deletions, per @niloc132:
|
engine/table/src/main/java/io/deephaven/engine/util/PickledResult.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/util/WorkerPythonEnvironment.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't think we have a real dependency on dill nor wrapt. Since we only support >= 3.7, numba is always required. And enum34 is never required. The Deprecated classes should eventually be removed, nothing uses them except tests.