Cleanup python deephaven package dependencies #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Potentially we should just delete WorkerPythonEnvironment, PickledResult, and python-engine-test. None of it is run, see #734 |
|
I've gone ahead with the further cleanup here. |
chipkent
previously requested changes
Jun 15, 2022
...n-engine-test/src/test/java/io/deephaven/engine/table/impl/select/PythonMatchFilterTest.java
Outdated
Show resolved
Hide resolved
python-engine-test/src/test/java/io/deephaven/engine/table/impl/select/TestConditionFilter.java
Outdated
Show resolved
Hide resolved
python-engine-test/src/test/java/io/deephaven/engine/util/TestWorkerPythonEnvironment.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/PickledResult.java
Outdated
Show resolved
Hide resolved
…ython-dependencies
devinrsmith
force-pushed
the
cleanup-deephaven-python-dependencies
branch
from
c0b8b22
to
ad46a93
Compare
|
I've removed the file deletions, per @niloc132:
|
jmao-denver
reviewed
Jun 27, 2022
engine/table/src/main/java/io/deephaven/engine/util/PickledResult.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/util/WorkerPythonEnvironment.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we have a real dependency on dill nor wrapt. Since we only support >= 3.7, numba is always required. And enum34 is never required. The Deprecated classes should eventually be removed, nothing uses them except tests.