Prevent parquet from closing zstd streams on finalization #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
previously approved these changes
Jun 27, 2022
rcaudy
requested changes
Jun 27, 2022
| */ | ||
| public class ZstdCodec extends ZstandardCodec { | ||
| @Override | ||
| public CompressionInputStream createInputStream(InputStream stream) throws IOException { |
There was a problem hiding this comment.
I think all of these changes belong in a differently-licensed module. Probably ParquetHadoop.
There was a problem hiding this comment.
Or we can make this module apache as well? (If it makes more sense to put into ParquetHadoop b/c they are intimately related, then I agree that might be best.)
There was a problem hiding this comment.
I moved the code for the moment anyway, but if we end up adding much more in this compression stuff I think it could be nice to open that up, offer as a different option than the upstream CompressionCodecFactory(s).
rcaudy
reviewed
Jun 28, 2022
...uetHadoop/src/main/java/io/deephaven/parquet/compress/codec/zstd/ZstdDecompressorStream.java
Outdated
Show resolved
Hide resolved
…c/zstd/ZstdDecompressorStream.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
approved these changes
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2569