Simplify ColumnExpressionValidator #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
force-pushed
the
simplify-column-expr-validator
branch
2 times, most recently
from
b7f7212
to
5567c41
Compare
devinrsmith
force-pushed
the
simplify-column-expr-validator
branch
from
5567c41
to
8a15bc9
Compare
rcaudy
reviewed
Jul 21, 2022
| @@ -129,7 +129,7 @@ public String toString() { | |||
| } | |||
|
|
|||
| public SelectColumn getRealColumn() { | |||
| return realColumn; | |||
| return Require.neqNull(realColumn, "realColumn"); | |||
There was a problem hiding this comment.
There's a bit of inconsistency in this. Some methods check it, others don't, and none are going to give an appropriate error message. Maybe the other accesses should thread through getRealColumn(), and maybe it should have a better validation, like:
if (realColumn == null) {
throw new IllegalStateException(
"Real column is not available until this SwitchColumn is initialized; ensure that initInputs or initDef has been called first"
);
}
server/src/main/java/io/deephaven/server/table/validation/ColumnExpressionValidator.java
Outdated
Show resolved
Hide resolved
rcaudy
approved these changes
Jul 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.