Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create java client tests for view, update, updateView, select, where, and aggBy #2652

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Create java client tests for view, update, updateView, select, where, and aggBy #2652

merged 4 commits into from
Jul 21, 2022

Conversation

devinrsmith
Copy link
Member

No description provided.

@devinrsmith devinrsmith added this to the Jul 2022 milestone Jul 19, 2022
@devinrsmith devinrsmith self-assigned this Jul 19, 2022
@devinrsmith devinrsmith marked this pull request as ready for review July 19, 2022 21:39
rcaudy
rcaudy previously approved these changes Jul 19, 2022
View reviewed changes
@devinrsmith devinrsmith changed the title Create tests for UpdateOrSelectGrpcImpl Create java client tests for view, update, updateView, select, where, and aggBy Jul 20, 2022
@devinrsmith devinrsmith requested a review from rcaudy July 20, 2022 19:23
rcaudy
rcaudy reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this testing code feels repetitive/redundant, but it seems fine.

@devinrsmith devinrsmith merged commit faf3826 into deephaven:main Jul 21, 2022
@devinrsmith devinrsmith deleted the update-or-select-grpc-test branch July 21, 2022 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@niloc132 niloc132 Awaiting requested review from niloc132

Assignees

@devinrsmith devinrsmith

Labels
NoDocumentationNeeded test
Projects
None yet
Milestone
Jul 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@devinrsmith @rcaudy