Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Figure Generator to allow nullable parameters #2687

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jul 26, 2022

  • Allow parameters to be specified as nullable
  • For nullable parameters, don't check that they're not null when verifying
  • Tested with my treemap-cleanup branch (not yet posted for review)

- Allow parameters to be specified as nullable
- For nullable parameters, don't check that they're not null when verifying
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mofojed mofojed merged commit 9c56450 into deephaven:main Jul 28, 2022
@mofojed mofojed deleted the plot-generator branch July 28, 2022 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants