-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to Pool / re use compressors where possible. Fixes #2788 #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use compressors where possible
Closed
niloc132
reviewed
Sep 7, 2022
...mpression/src/main/java/io/deephaven/parquet/compress/DeephavenCompressorAdapterFactory.java
Outdated
Show resolved
Hide resolved
extensions/parquet/base/src/main/java/io/deephaven/parquet/base/ColumnChunkReaderImpl.java
Show resolved
Hide resolved
...mpression/src/main/java/io/deephaven/parquet/compress/DeephavenCompressorAdapterFactory.java
Outdated
Show resolved
Hide resolved
niloc132
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Filed a follow-up issue #2920 for myself, unless you want to handle any of these points in this patch.
- Disable/fix meaningless "Got brand-new [de]compressor" messages.
zstd
,lzo
, andgzip
end up logging multiple times when decompressing each table, andzstd
andgzip
also multiple times when compressing. - Once we find that we can't ask the pool for a compressor, quit asking. This will somewhat mitigate the above, but also keeps us from doing the extra work of asking the pool for an instance we know we can't find (which itself requires taking the lock, etc). Specifically, if
innerCompressor
is null and the compress method ends up callingcompressionCodec.createOutputStream(os)
, we should keep track of that fact. This will specifically protect the zstd and gzip codecs from having to rediscover this for each page within each column, as well as for the dictionary for each column. - For x86, investigate providing the native codec, which will enable the gzip codec not worry about the above case and pool its de/compressors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.