Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python specific checks for parallel evaluation of formulas #2813

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

jmao-denver
Copy link
Contributor

@jmao-denver jmao-denver commented Sep 7, 2022

The change in JPY to release the GIL whenever a Java method is called has made the check to prevent potential deadlock unnecessary.

Fixes #2742

Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the code, and I think it does what it purports to. We have a wider discussion about the resulting performance to account for before we merge this.

@jmao-denver jmao-denver merged commit 4a02670 into deephaven:main Sep 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2022
@jmao-denver jmao-denver deleted the 2742-parallel-formula-eval branch February 8, 2023 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable parallel formula evaluation in the Python script session.
2 participants