Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix improper initial magic number placement in Parquet writing, thereby also "fixing" dictionary offset 0 issue #2820

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Fix improper initial magic number placement in Parquet writing, thereby also "fixing" dictionary offset 0 issue #2820

merged 1 commit into from
Sep 8, 2022

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Sep 7, 2022

Fixes #2806

@rcaudy rcaudy added bug Something isn't working parquet Related to the Parquet integration NoDocumentationNeeded labels Sep 7, 2022
@rcaudy rcaudy added this to the Sept 2022 milestone Sep 7, 2022
@rcaudy rcaudy self-assigned this Sep 7, 2022
@rcaudy rcaudy merged commit f1d8922 into deephaven:main Sep 8, 2022
@rcaudy rcaudy deleted the rwc-parquetfix branch September 8, 2022 02:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abaranec abaranec abaranec approved these changes

@jcferretti jcferretti Awaiting requested review from jcferretti

Assignees

@rcaudy rcaudy

Labels
bug Something isn't working NoDocumentationNeeded parquet Related to the Parquet integration
Projects
None yet
Milestone
Sept 2022
Development

Successfully merging this pull request may close these issues.

Parquet writing is producing invalid files
2 participants
@rcaudy @abaranec