Add RollingSum operator to updateBy()
#2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
reviewed
Jan 31, 2023
...src/main/java/io/deephaven/engine/table/impl/updateby/internal/BaseCharUpdateByOperator.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/deephaven/engine/table/impl/updateby/internal/BaseCharUpdateByOperator.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/deephaven/engine/table/impl/updateby/internal/BaseObjectBinaryOperator.java
Outdated
Show resolved
Hide resolved
More error handling improvements
…eby-ops # Conflicts: # engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/BucketedPartitionedUpdateByManager.java # engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/UpdateByBucketHelper.java
lbooker42
changed the title
updateBy()RollingSum operator to updateBy()
This was referenced Feb 1, 2023
rcaudy
previously approved these changes
Feb 1, 2023
rcaudy
previously approved these changes
Feb 1, 2023
…yEnclosed should ensure reachability to make sure referents can't escape the LivenessScope.release.
…if source.isRefreshing()" code in one place, and to ensure proper proactive liveness cleanup for the PartitionedTables.
Address PartitionedTable liveness leak inside bucketed UpdateBy
rcaudy
approved these changes
Feb 2, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/2148 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very large commit containing the back-end support for all upcoming windowed/rolling operators and the full implementation of
RollingSum.Closes #2624