Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap consumeToPartitionedTable in Python #2904

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Wrap consumeToPartitionedTable in Python #2904

merged 3 commits into from
Sep 23, 2022

Conversation

jmao-denver
Copy link
Contributor

Fixes #2901

@jmao-denver jmao-denver added this to the Sept 2022 milestone Sep 23, 2022
@jmao-denver jmao-denver self-assigned this Sep 23, 2022
rcaudy
rcaudy reviewed Sep 23, 2022
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment regarding documentation.

py/server/deephaven/stream/kafka/consumer.py Outdated Show resolved Hide resolved
@devinrsmith devinrsmith self-requested a review September 23, 2022 17:48
devinrsmith
devinrsmith approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See earlier comment.

@jmao-denver jmao-denver merged commit f5b1576 into deephaven:main Sep 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
@jmao-denver jmao-denver deleted the 2901-kafka-to-partitioned-table branch February 8, 2023 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@devinrsmith devinrsmith devinrsmith approved these changes

Assignees

@jmao-denver jmao-denver

Labels
NoDocumentationNeeded partitioned_tables python-server-side
Projects
None yet
Milestone
Sept 2022
Development

Successfully merging this pull request may close these issues.

Python Kafka partitioned table support
3 participants
@jmao-denver @rcaudy @devinrsmith