Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump guava #2950

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Bump guava #2950

merged 1 commit into from
Oct 6, 2022

Conversation

devinrsmith
Copy link
Member

Previous dependency resolution inherited from:

com.google.guava:guava:31.0.1-android
+--- io.grpc:grpc-api:1.46.0

Previous dependency resolution inherited from:

com.google.guava:guava:31.0.1-android
+--- io.grpc:grpc-api:1.46.0
@devinrsmith
Copy link
Member Author

Question: should we depend on the -jre or -android flavor?

@niloc132
Copy link
Member

niloc132 commented Oct 6, 2022

There may come a time when we want android, but I don't think it will be terrible soon.

@devinrsmith devinrsmith merged commit fa40d4e into deephaven:main Oct 6, 2022
@devinrsmith devinrsmith deleted the bump-guava branch October 6, 2022 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants