Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload error logs on pydoc failure #2961

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Oct 5, 2022

This is meant to catch JVM error logs of the format **/*_pid*.log. This is something we've seen from the pydoc task / sphinx / jpy.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the PR description with more details, such as "What logs are uploaded?" "Where do these logs go/how do I check them in event of a failure?"

.github/workflows/docs-ci.yml Show resolved Hide resolved
@devinrsmith devinrsmith merged commit 4b061d3 into deephaven:main Oct 5, 2022
@devinrsmith devinrsmith deleted the upload-jvm-err-for-pydocs branch October 5, 2022 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants