Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OHLC charttype, XY will be used instead. #2988

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

niloc132
Copy link
Member

Marked as draft for now, since it no longer errors out on the server, but the client doesn't render both series, only the xy plot is drawn for either sample query.

Fixes #2094

@mofojed
Copy link
Member

mofojed commented Oct 27, 2022

Mentioned in a chat, but repeating here to keep context together - with this change currently the series plotStyle being received by the UI is dh.plot.SeriesPlotStyle.LINE, when it should still be dh.plot.SeriesPlotStyle.OHLC, it should just be the chart type that is changes to .XY instead of .OHLC.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Series plotStyle should still be .OHLC.

@niloc132 niloc132 marked this pull request as ready for review November 11, 2022 18:57
@niloc132 niloc132 requested a review from mofojed December 1, 2022 15:38
@niloc132 niloc132 merged commit 3f7bd07 into deephaven:main Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when plotting xy plot over OHLC plot
2 participants