-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code to cpp-client/build.gradle to run tests in docker. #3006
Add code to cpp-client/build.gradle to run tests in docker. #3006
Conversation
Separated out from deephaven/deephaven-core#3006
Separated out from deephaven/deephaven-core#3006
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some micro-comments.
Just for reference, the base image will be our largest yet, topping in at over 3GB.
|
Devin and myself discussed making a docker ARG for image generation setting BUILD_TYPE=Release as default; the build-dependencies.sh script itself is not changing, but the way it is invoked from the dockerfile will change to use the ARG. This results in a more economical image:
I tried that locally, I am updating the PR for deephaven-base-images right after writing this. |
This does not include yet code to automatically check consistency of generated protos, that should come in a later PR.
Summary of changes:
build-dependencies.sh
, now lives in the deephaven-base-images repository (https://github.com/deephaven/deephaven-base-images/tree/main/cpp-client). The script there is refactored some, to allow for building individual parts. Also made the script write a newenv.sh
file at the end with environment variables to source for, eg,CMAKE_PREFIX_PATH
. UpdatedREADME.md
to reflect the change.we have added code to create a "cpp-client-base" image (code here) that contains all the dependent libraries already built
in ubuntu-22.04. The code added to
cpp-client/build.gradle
to do checks via docker leans on that to avoidhaving to wait too long and create too many layer of the new image.
tests/test_util.cc
to support changing the host:port for the server via setting environment variablesDH_HOST
andDH_PORT
, needed for automating the tests.