Disable autocomplete for python sessions #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
force-pushed
the
3024-disable-py-autocomplete
branch
from
2e990ec
to
2a50774
Compare
mofojed
approved these changes
Oct 27, 2022
mofojed
requested changes
Oct 27, 2022
There was a problem hiding this comment.
The oddities you were observing is because the request ID wasn't being set, so then in IdeSession it couldn't map them back to the original pending autocomplete request.
server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
…eGrpcImpl.java Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
Oct 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3024