-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Configuration #3035
Merged
Merged
Simplify Configuration #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
force-pushed
the
workspace-cleanup
branch
2 times, most recently
from
October 28, 2022 19:02
d86677e
to
9f8fc7e
Compare
Introduces deephaven.cacheDir, deephaven.configDir, and deephaven.dataDir. During server startup, if not explicitly provided, these values will be choosen based on the current user and operating system conventions.
devinrsmith
force-pushed
the
workspace-cleanup
branch
from
October 28, 2022 19:05
9f8fc7e
to
2704b4b
Compare
devinrsmith
commented
Oct 28, 2022
rcaudy
reviewed
Oct 28, 2022
ModelFarm/src/test/java/io/deephaven/modelfarm/TestModelInputSerializerDeserializer.java
Outdated
Show resolved
Hide resolved
docker/server-jetty/src/main/configure/image-bootstrap.properties
Outdated
Show resolved
Hide resolved
engine/updategraph/src/main/java/io/deephaven/engine/liveness/Liveness.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Nov 2, 2022
rcaudy
reviewed
Nov 2, 2022
follow up #3055 |
follow up #3054 |
rcaudy
approved these changes
Nov 2, 2022
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/1854 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
deephaven.cacheDir
,deephaven.configDir
,deephaven.dataDir
, anddeephaven.application
(and corresponding environment variable alternatives).During server startup, if not explicitly provided, these values will be chosen based on the current user and operating system conventions.