Multiplexed websocket instances should remove handlers when finished #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes a workaround for a NodeJS WebSocket polyfill, which doesn't use the expected CloseEvent/MessageEvent constructors. Fixes deephaven#3063
devinrsmith
approved these changes
Nov 4, 2022
mattrunyon
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Appears to be working. In the browser I set a breakpoint where the websocket is created in dh-core and stored as a global variable. Then calling getEventListeners(temp1) you can see the listeners attached. Started at 6. Opening a table went to 8. Closing the panel went to 7. Re-opening went back to 8. Closing again back to 7.
In Node for the snapshot tool, the number of handlers slowly creeps up, but I may be flooding the server or the cleanup is being delayed. Or I have a case I'm not handling in the overload I have to do to patch the Node ws to more closely match the browser. I'm seeing about 75% on a given event are closed, but possible it's entirely my fault
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a workaround for a NodeJS WebSocket polyfill, which doesn't use the expected CloseEvent/MessageEvent constructors.
Fixes #3063