Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call pkgutil.walk_packages with prefix set to 'deephaven' in _recursive_import #3072

Merged

Conversation

jmao-denver
Copy link
Contributor

@jmao-denver jmao-denver commented Nov 7, 2022

Also simplified the _recursive_import as wal_packages() already recursively imports all the packages.

Fixes #3071

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. I was able to test this out and it did solve the issue.

@jmao-denver jmao-denver merged commit b84b067 into deephaven:main Nov 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
@jmao-denver jmao-denver deleted the 3071-recursive-import-failure branch March 31, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URI resolve does not work if deephaven-plugin-matplotlib is installed
2 participants