Move completer to deephaven_internal #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to deephaven#3114
devinrsmith
added
clean up
NoDocumentationNeeded
NoReleaseNotesNeeded
jmao-denver
reviewed
Dec 2, 2022
| from deephaven.completer import jedi_settings | ||
| from deephaven_internal.completer import jedi_settings |
There was a problem hiding this comment.
Could we rename it to auto_completer as suggested by Chip?
There was a problem hiding this comment.
I acutally suggested autocomplete
There was a problem hiding this comment.
Another thing we might want to take care of is the enum names in _completer.py, our convention is to use all CAPS (also requested by Chip in the original PR)
jmao-denver
reviewed
Dec 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3114