Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency on autocomplete feature for PyPi deephaven-server #3140

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Add dependency on autocomplete feature for PyPi deephaven-server #3140

merged 1 commit into from
Dec 5, 2022

Conversation

devinrsmith
Copy link
Member

Follow-up to #3114

@devinrsmith devinrsmith added NoDocumentationNeeded dependencies Pull requests that update a dependency file NoReleaseNotesNeeded No release notes are needed. labels Dec 2, 2022
@devinrsmith devinrsmith added this to the Nov 2022 milestone Dec 2, 2022
@devinrsmith devinrsmith self-assigned this Dec 2, 2022
niloc132
niloc132 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I'd rather optional dependencies remain optional, but this seems like more trouble than it is worth at this time.

@devinrsmith devinrsmith merged commit 1cc882b into deephaven:main Dec 5, 2022
@devinrsmith devinrsmith deleted the py-embedded-server-autocomplete branch December 5, 2022 16:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niloc132 niloc132 niloc132 approved these changes

@chipkent chipkent chipkent approved these changes

Assignees

@devinrsmith devinrsmith

Labels
dependencies Pull requests that update a dependency file NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
Nov 2022
Development

Successfully merging this pull request may close these issues.
3 participants
@devinrsmith @niloc132 @chipkent