Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't write an all-null column with a dictionary #3141

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Don't write an all-null column with a dictionary #3141

merged 5 commits into from
Dec 6, 2022

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Dec 2, 2022

Fixes #3134

@niloc132 niloc132 added parquet Related to the Parquet integration NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Dec 2, 2022
@niloc132 niloc132 marked this pull request as ready for review December 5, 2022 22:51
jmao-denver
jmao-denver previously approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niloc132 niloc132 mentioned this pull request Dec 6, 2022
Open
jmao-denver
jmao-denver approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niloc132 niloc132 merged commit c22c68c into deephaven:main Dec 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmao-denver jmao-denver jmao-denver approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees
No one assigned
Labels
NoDocumentationNeeded parquet Related to the Parquet integration ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files written with Snappy codec cannot be read by pyarrow
2 participants
@niloc132 @jmao-denver