Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance for ConstituentDependency, tighter double-notification testing, MergeListener paranoia #3142

Merged
merged 17 commits into from
Dec 6, 2022
Merged

Improve performance for ConstituentDependency, tighter double-notification testing, MergeListener paranoia #3142

merged 17 commits into from
Dec 6, 2022

Commits on Dec 2, 2022

  1. SelectOrUpdateListener to defer notification delivery until all depen… 

    …dency column values added/removed/modified on this cycle are satisfied
    @rcaudy
    rcaudy committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    47ad711 View commit details
    Browse the repository at this point in the history

  2. Tighten expectations for notification delivery in BaseTable

    @rcaudy
    rcaudy committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    efc2546 View commit details
    Browse the repository at this point in the history

  3. MergedListener should be a little more cautious about double-notifies

    @rcaudy
    rcaudy committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    3839ab3 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. Unit test to reproduce theorized dependency error (if we disable the … 

    …code that guards against it)
    @rcaudy
    rcaudy committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    fbc8242 View commit details
    Browse the repository at this point in the history

  2. Optimizations to ConstituentDependency: avoid concurrent checks, reco… 

    …rd lowest unsatisfied constituent position to resume from
    @rcaudy
    rcaudy committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    76576b7 View commit details
    Browse the repository at this point in the history

  3. Account for SyncTableFilter weirdness, and allow failure notification… 

    … after update on the same cycle
    @rcaudy
    rcaudy committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    91f5603 View commit details
    Browse the repository at this point in the history

  4. Revert "SelectOrUpdateListener to defer notification delivery until a… 

    …ll dependency column values added/removed/modified on this cycle are satisfied"

This reverts commit 47ad711.
    @rcaudy
    rcaudy committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    97f2d1b View commit details
    Browse the repository at this point in the history

  5. Add a correctness assertion for resumption support in ConstituentDepe… 

    …ndency
    @rcaudy
    rcaudy committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    fd56f89 View commit details
    Browse the repository at this point in the history

  6. Revert "Account for SyncTableFilter weirdness, and allow failure noti… 

    …fication after update on the same cycle"

This reverts commit 91f5603.
    @rcaudy
    rcaudy committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    60b962c View commit details
    Browse the repository at this point in the history

  7. Support next-cycle error notification when needed in MergedListener, … 

    …update SyncTableFilter accordingly
    @rcaudy
    rcaudy committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    636fdb6 View commit details
    Browse the repository at this point in the history

  8. Spotless

    @rcaudy
    rcaudy committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    041bb6b View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Get rid of ShiftObliviousSwapListener

    @rcaudy
    rcaudy committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    6389f7f View commit details
    Browse the repository at this point in the history

  2. Switch from SwapListener as a permanent link in the DAG to a temporar… 

    …y one which is always eliminated by the end of the instantiation cycle
    @rcaudy
    rcaudy committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    f530c00 View commit details
    Browse the repository at this point in the history

  3. Spotless

    @rcaudy
    rcaudy committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    1bce6bf View commit details
    Browse the repository at this point in the history

  4. Clean up some mistaken references to ShiftOblivious listeners

    @rcaudy
    rcaudy committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    b760113 View commit details
    Browse the repository at this point in the history

  5. Fix some missing destroy and manage calls

    @rcaudy
    rcaudy committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    888778a View commit details
    Browse the repository at this point in the history

  6. Correct a name

    @rcaudy
    rcaudy committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    985be2b View commit details
    Browse the repository at this point in the history