Barrage: Encode Packed Booleans Instead of Reinterpretted Bytes #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
barrage
NoDocumentationNeeded
arrow
ReleaseNotesNeeded
nbauernfeind
force-pushed
the
barrage_bool
branch
2 times, most recently
from
79817dd
to
82ec976
Compare
lbooker42
reviewed
Dec 19, 2022
...ge/src/main/java/io/deephaven/extensions/barrage/chunk/BooleanChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...ge/src/main/java/io/deephaven/extensions/barrage/chunk/BooleanChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
niloc132
reviewed
Dec 19, 2022
web/client-api/src/main/java/io/deephaven/web/client/api/barrage/BarrageUtils.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Dec 21, 2022
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
barrage_bool
branch
from
8286d88
to
903bf7d
Compare
nbauernfeind
force-pushed
the
barrage_bool
branch
from
903bf7d
to
f0ee8af
Compare
niloc132
previously approved these changes
Jan 3, 2023
web/client-api/src/main/java/io/deephaven/web/client/api/barrage/WebBarrageUtils.java
Outdated
Show resolved
Hide resolved
niloc132
approved these changes
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43.
This round trips with java flight, c++ flight, and deephaven's web ui.