Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default_groovy.env #3219

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fix default_groovy.env #3219

merged 1 commit into from
Jan 3, 2023

Conversation

devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Dec 20, 2022 •
edited
Loading

DEEPHAVEN_SERVER_IMAGE was set to an outdated image. This sets it correctly. Tested with:

./gradlew prepareCompose
docker compose --env-file default_groovy.env up

@devinrsmith devinrsmith added bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Dec 20, 2022
@devinrsmith devinrsmith added this to the Dec 2022 milestone Dec 20, 2022
@devinrsmith devinrsmith self-assigned this Dec 20, 2022
mofojed
mofojed approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also like a PR description - why did the default image name change? Why is server-slim no longer appropriate? How did you test?

@devinrsmith devinrsmith merged commit 178bbb4 into deephaven:main Jan 3, 2023
@devinrsmith devinrsmith deleted the update-groovy-env branch January 3, 2023 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mofojed mofojed mofojed approved these changes

@jjbrosnan jjbrosnan Awaiting requested review from jjbrosnan

Assignees

@devinrsmith devinrsmith

Labels
bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
Dec 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@devinrsmith @mofojed