Port DH-11933: Constant Formulas Should use SingleValueColumnSources #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
query engine
NoDocumentationNeeded
port
ReleaseNotesNeeded
cpwright
previously approved these changes
Jan 19, 2023
nbauernfeind
force-pushed
the
dh_11933
branch
from
89bdb9f
to
4f8a2c7
Compare
cpwright
approved these changes
Jan 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a little creative freedom to keep code style more consistent with DHC. There were some incorrect generic parameters in DHE that are fixed here. In DHC, SelectColumns are aggressively initialized before they reach the analyzer. Some comments were updated/removed to reflect this. I also inlined the helper method added to SelectColumn as it only applies to a very specific subset of DhFormulaColumn and only needs to be invoked by the FormulaAnalyzer.
The internal JIRA Ticket: DH-11933
The internal commit.
Nightlies are running here.