Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proto-generated files for cpp-client #3333

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

niloc132
Copy link
Member

Branch is a draft since it appears to have compiler errors, but as far as I can tell, this is what you get from following the current manual steps to generate new cpp.

Copy link
Contributor

@kosak kosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (I pushed a commit to suppress the warning about deprecated declarations)

@niloc132 niloc132 marked this pull request as ready for review January 20, 2023 02:15
@niloc132 niloc132 merged commit 26d69fa into deephaven:main Jan 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants