Remove the extra python base images #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
added
build
ci
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
changed the title
devinrsmith
changed the title
devinrsmith
requested review from
jcferretti,
rcaudy,
JamesXNelson and
mofojed
as code owners
niloc132
previously approved these changes
Jan 20, 2023
rcaudy
reviewed
Feb 2, 2023
There was a problem hiding this comment.
Seems to me like there are inconsistent deletions w.r.t. tensorflow. Can you explain, @devinrsmith ?
|
@rcaudy forgot a few deletions, added them, repushed. |
rcaudy
approved these changes
Feb 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra python -base images are mostly fluff wrt this repository; previously with netty, the base images were used as part of the build and publish workflow. With jetty, the build and publish workflow is in https://github.com/deephaven/deephaven-server-docker, so keeping them dangling over here has little value.