-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass arrays from vector type columns unpacked to Python func #3458
Merged
jmao-denver
merged 3 commits into
deephaven:main
from
jmao-denver:2577-grouped-column-arg-py
Mar 3, 2023
Merged
Pass arrays from vector type columns unpacked to Python func #3458
jmao-denver
merged 3 commits into
deephaven:main
from
jmao-denver:2577-grouped-column-arg-py
Mar 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
query engine
NoDocumentationNeeded
ReleaseNotesNeeded
Release notes are needed
labels
Feb 22, 2023
jmao-denver
force-pushed
the
2577-grouped-column-arg-py
branch
3 times, most recently
from
February 24, 2023 02:59
e5ec873
to
0a2e32d
Compare
jmao-denver
changed the title
WIP always conv vector into array for arg
Pass arrays from vector type columns unpacked to Python func
Feb 24, 2023
jmao-denver
force-pushed
the
2577-grouped-column-arg-py
branch
from
February 24, 2023 18:27
0a2e32d
to
2b42dc1
Compare
jmao-denver
force-pushed
the
2577-grouped-column-arg-py
branch
from
February 25, 2023 02:26
2b42dc1
to
d357282
Compare
chipkent
requested changes
Feb 27, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java
Show resolved
Hide resolved
jmao-denver
force-pushed
the
2577-grouped-column-arg-py
branch
from
February 28, 2023 17:51
d357282
to
f97dc6d
Compare
devinrsmith
reviewed
Feb 28, 2023
jmao-denver
force-pushed
the
2577-grouped-column-arg-py
branch
from
February 28, 2023 19:37
f97dc6d
to
fa7d1dd
Compare
chipkent
previously approved these changes
Feb 28, 2023
rcaudy
reviewed
Mar 3, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java
Outdated
Show resolved
Hide resolved
…/QueryLanguageParser.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2577