Move rpcWrapper to gRPC Interceptor; Open Session's ExecutionContext #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
grpc
clean up
NoDocumentationNeeded
NoReleaseNotesNeeded
nbauernfeind
force-pushed
the
wrap_rpc_at_injector
branch
from
2d9939b
to
e667c65
Compare
rcaudy
previously approved these changes
Mar 9, 2023
niloc132
reviewed
Mar 10, 2023
server/src/main/java/io/deephaven/server/arrow/ArrowFlightUtil.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
wrap_rpc_at_injector
branch
from
e667c65
to
43b3cea
Compare
nbauernfeind
changed the title
niloc132
approved these changes
Mar 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cleaned up the
rpcWrapperby moving it into the session object injection itself.I've also opened the session's ExecutionContext in the context of all gRPC requests.
DHE can now fetch the AuthContext during Ticket resolution as originally intended.
Nightlies are running here: https://github.com/nbauernfeind/deephaven-core/actions/runs/4370246882