Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide config service methods to java clients #3532

Merged
merged 6 commits into from
Mar 14, 2023

Conversation

niloc132
Copy link
Member

Refactors existing java-client grpc response observers into one shared implementation, so that all can be canceled.

Fixes #3528

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally nice abstraction. One big issue, subscribeToFields broken.

@devinrsmith devinrsmith self-requested a review March 13, 2023 20:30
@niloc132 niloc132 merged commit fa3abab into deephaven:main Mar 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java Client doesn't have a ConfigService as it does other services
3 participants