Improvements to Vectors using improved iteration and toArray patterns #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure, and trim down io.deephaven.util.FunctionalInterfaces. Clean up usages of removed interfaces by using standard java.lang or java.util.function alternatives, or by introducing a new, more local interface where appropriate.
…rfaces in io.deephaven.util.function, with slightly-improved documentation
… better match the equivalents in java.util.function, promote them to top-level, and move the whole heap to a new engine-primitive module
… block of code (shouldTrackPrevious) in CharacterSparseArraySource to a more appropriate location so it would not be duplicated by region duplication
…gBufferTest, and commit the code as-replicated
…functions {Byte, Char, Short}ToIntFunction and FloatToDoubleFunction, which enable adaptation to the built-int PrimitiveIterator specializations, and consequently to IntStream and DoubleStream as appropriate. Extend this stream support to the new iterator interfaces, and use the new iterator interfaces for the ColumnIterators as appropriate.
…nings and missed coverage issues
…able, standardized code formatting and naming conventions, etc.
…eness for primitive iterators
…e/primitive iterators
…tion for all vector methods, rather than serial-get. Eliminate Prev*VectorColumnWrappers.
…rsions. Fixed a bunch of inspections and warnings in chunk code. Addressed unnecessarily-restrictive chunk attributes in sort kernels, and did some code cleanup there. Fixed a few bad downcasts.
…and resettable (disabled) chunks
… for methods that are in TableDefaults but should instead be in QueryTable and TableAdapter
…e assertive about types
…e threshold, defaulted to 128
…ations. Add serial implementations, and switch between the options in vectors based on a size threshold.
|
Nightlies look good |
chipkent
previously approved these changes
Mar 20, 2023
kosak
reviewed
Mar 20, 2023
kosak
reviewed
Mar 20, 2023
engine/api/src/main/java/io/deephaven/engine/table/iterators/ColumnIterator.java
Outdated
Show resolved
Hide resolved
engine/api/src/main/java/io/deephaven/engine/table/iterators/ColumnIterator.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/deephaven/engine/primitive/iterator/CloseablePrimitiveIteratorOfChar.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/deephaven/engine/primitive/iterator/CloseablePrimitiveIteratorOfChar.java
Show resolved
Hide resolved
...e/src/main/java/io/deephaven/engine/primitive/iterator/CloseablePrimitiveIteratorOfChar.java
Show resolved
Hide resolved
...e/src/main/java/io/deephaven/engine/primitive/iterator/CloseablePrimitiveIteratorOfChar.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sort/ByteSortKernel.java
Outdated
Show resolved
Hide resolved
...ne/table/src/main/java/io/deephaven/engine/table/impl/sort/timsort/ByteIntTimsortKernel.java
Show resolved
Hide resolved
Base/src/main/java/io/deephaven/base/pool/ThreadSafeLenientFixedSizePool.java
Outdated
Show resolved
Hide resolved
base-test-utils/src/main/java/io/deephaven/base/testing/BaseCachedJMockTestCase.java
Outdated
Show resolved
Hide resolved
engine/api/src/main/java/io/deephaven/engine/table/iterators/SerialColumnIterator.java
Outdated
Show resolved
Hide resolved
engine/api/src/main/java/io/deephaven/engine/table/iterators/SerialObjectColumnIterator.java
Outdated
Show resolved
Hide resolved
engine/chunk/src/main/java/io/deephaven/chunk/util/pools/ObjectChunkPool.java
Outdated
Show resolved
Hide resolved
...e/table/src/main/java/io/deephaven/engine/table/impl/util/FunctionGeneratedTableFactory.java
Outdated
Show resolved
Hide resolved
engine/api/src/main/java/io/deephaven/engine/table/iterators/SerialColumnIterator.java
Outdated
Show resolved
Hide resolved
… Replication for ObjectVectorTest.
… changes, but rather by the fix to test table sizing.
nbauernfeind
approved these changes
Mar 21, 2023
chipkent
approved these changes
Mar 21, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/2314 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a major overhaul of our functional interfaces, new primitive iterator and closeable iterators, and many other cleanups. Deletes deprecated
BooleanVectorcode.Closes #3206
Closes #3207