-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Exponential Moving Sum
to UpdateBy
operators
#3663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick overview, didn't get deep into the operator logic. Will trial out the operator and report back.
table-api/src/main/java/io/deephaven/api/updateby/UpdateByOperation.java
Outdated
Show resolved
Hide resolved
java-client/session/src/main/java/io/deephaven/client/impl/UpdateByBuilder.java
Outdated
Show resolved
Hide resolved
java-client/session/src/test/java/io/deephaven/client/impl/UpdateBySpecBuilderTest.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/DoubleEMSOperator.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BasePrimitiveEMSOperator.java
Outdated
Show resolved
Hide resolved
Mentioned in DM, but there may be a way to share operator implementations among Exponential Moving Avg / Sum / Min / Max. There also may be ways to share construction of them to make it easier for end user? For example, it might be cool to have specifically typed helpers off of existing specs: avg().exponential(window(...))
sum_().exponential(window(...))
avg().rolling(window(...))
... |
Creating a shared Exponential Moving implementations is clever and I will refactor in a follow-on PR (likely |
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/UpdateByOperatorFactory.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BaseBigNumberEMSOperator.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BaseBigNumberEMSOperator.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BasePrimitiveEMSOperator.java
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BigDecimalEMSOperator.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BigIntegerEMSOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/CharEMSOperator.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/CharEMSOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/FloatEMSOperator.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/FloatEMSOperator.java
Outdated
Show resolved
Hide resolved
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/2452 |
Closes #2760