Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to pick up pandas 2 #3664

Merged

Conversation

devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Apr 5, 2023

Fixes #3573

@devinrsmith devinrsmith added this to the Apr 2023 milestone Apr 5, 2023
@devinrsmith devinrsmith self-assigned this Apr 5, 2023
@devinrsmith
Copy link
Member Author

Note: the python environment is blocking release of this currently, failing w/ the new pandas 2 and:

======================================================================
FAIL [3.044s]: test_round_trip_data (tests.test_parquet.ParquetTestCase)
Pass data between DH and pandas via pyarrow, making sure each side can read data the other side writes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/python/tests/test_parquet.py", line 186, in test_round_trip_data
    self.round_trip_with_compression("UNCOMPRESSED", dh_table)
  File "/python/tests/test_parquet.py", line 200, in round_trip_with_compression
    self.assert_table_equals(dh_table, result_table)
  File "/python/tests/testbase.py", line 73, in assert_table_equals
    self.assertTrue(table_equals(table_a, table_b))
AssertionError: False is not true

#3573 will need to be resolved before the python environments can be updated in this fashion.

@devinrsmith devinrsmith force-pushed the nightly/bump-images-post-release branch from 99ae38a to aae7b75 Compare April 6, 2023 18:18
@devinrsmith devinrsmith marked this pull request as ready for review April 6, 2023 21:21
@devinrsmith devinrsmith changed the title Bump all registry images post release Bump to pick up pandas 2 Apr 10, 2023
@devinrsmith
Copy link
Member Author

Nightlies have passed.

Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinrsmith devinrsmith enabled auto-merge (squash) April 10, 2023 18:04
@devinrsmith devinrsmith merged commit ba457b3 into deephaven:main Apr 10, 2023
@devinrsmith devinrsmith deleted the nightly/bump-images-post-release branch April 10, 2023 18:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deephaven.pandas module should support Pandas 2.0 with the new Arrow backend for storing data
3 participants