Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle None input values for primitive type columns in new_table() #3729

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

jmao-denver
Copy link
Contributor

@jmao-denver jmao-denver commented Apr 24, 2023

Fixes #3688

@jmao-denver jmao-denver added this to the Apr 2023 milestone Apr 24, 2023
@jmao-denver jmao-denver self-assigned this Apr 24, 2023
@jmao-denver jmao-denver changed the title Correctly handle None input value for primitive type columns in new_table() Correctly handle None input values for primitive type columns in new_table() Apr 24, 2023
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

py/server/deephaven/dtypes.py Show resolved Hide resolved
@jmao-denver jmao-denver merged commit a459979 into deephaven:main Apr 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
@jmao-denver jmao-denver deleted the 3688-new-table-num-nulls branch May 3, 2023 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None does not map to Deephaven nulls for numeric _cols
3 participants