Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blink time_table support #3940

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Add blink time_table support #3940

merged 2 commits into from
Jun 9, 2023

Conversation

devinrsmith
Copy link
Member

No description provided.

@devinrsmith devinrsmith added this to the June 2023 milestone Jun 5, 2023
@devinrsmith devinrsmith self-assigned this Jun 5, 2023
jmao-denver
jmao-denver reviewed Jun 5, 2023
View reviewed changes
py/server/tests/test_table_factory.py
Comment on lines +69 to +71
self.assertEqual(1, len(t.columns))
self.assertTrue(_JBlinkTableTools.isBlink(t.j_table))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to add a property 'is_blinking' to Table?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd want to add io.deephaven.engine.table.Table#isBlink before we added it to the python side. Note: io.deephaven.engine.table.impl.BaseTable#isBlink exists, but is scoped to the implementations, not the interface. Should we elevate to engine Table interface @rcaudy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless, I think that would be a new issue / PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's defer adding anything to the table interface. Users who really want to know can look at attributes for now.

rcaudy
rcaudy reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, deferring to Jianfeng and/or Chip for Python approval.

jmao-denver
jmao-denver approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmao-denver jmao-denver merged commit 2827511 into deephaven:main Jun 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/2757
Conceptual: https://github.com/deephaven/deephaven.io/issues/2755
Reference: https://github.com/deephaven/deephaven.io/issues/2754
Blog: https://github.com/deephaven/deephaven.io/issues/2756

@devinrsmith devinrsmith deleted the add-blink-table-param-time-table branch June 9, 2023 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy left review comments

@jmao-denver jmao-denver jmao-denver approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

Assignees

@devinrsmith devinrsmith

Labels
DocumentationNeeded NoReleaseNotesNeeded No release notes are needed. python-server-side
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@devinrsmith @deephaven-internal @jmao-denver @rcaudy