PeriodicUpdateGraph: Fix thread count and initialization order bugs; update_graph.py: Don't deadlock transforms via auto-locking #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct update thread count. Fix some naming issues for instance members.
rcaudy
added
bug
|
Nightlies are running at https://github.com/rcaudy/deephaven-core/actions/runs/5247976008 |
nbauernfeind
previously approved these changes
Jun 12, 2023
nbauernfeind
previously approved these changes
Jun 13, 2023
…essing threads until the PUG is actually starting; blow up if anyone tries to use the PUG before that has been done
…his will avoid deadlocking in concurrent transforms PeriodicUpdateGraph: spotless RangeJoinOperation: minor simplification
rcaudy
changed the title
jmao-denver
previously approved these changes
Jun 13, 2023
chipkent
previously approved these changes
Jun 13, 2023
jmao-denver
approved these changes
Jun 13, 2023
nbauernfeind
approved these changes
Jun 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3978
Fixes #3906