Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore parentheses when check vectorizability #4038

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Ignore parentheses when check vectorizability #4038

merged 2 commits into from
Jun 21, 2023

Conversation

jmao-denver
Copy link
Contributor

Fixes #4036

@jmao-denver jmao-denver added this to the June 2023 milestone Jun 21, 2023
@jmao-denver jmao-denver self-assigned this Jun 21, 2023
cpwright
cpwright previously approved these changes Jun 21, 2023
View reviewed changes
rcaudy
rcaudy previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why did the original version return a String?

chipkent
chipkent requested changes Jun 21, 2023
View reviewed changes
py/server/tests/test_vectorization.py Outdated Show resolved Hide resolved
@jmao-denver jmao-denver dismissed stale reviews from rcaudy and cpwright via 1e152a5 June 21, 2023 16:45
@jmao-denver jmao-denver merged commit bd266f0 into deephaven:main Jun 21, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
@jmao-denver jmao-denver deleted the 4036-py-udf-parens branch July 17, 2023 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

@cpwright cpwright Awaiting requested review from cpwright

Assignees

@jmao-denver jmao-denver

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. python-server-side query engine
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

Parentheses around a Python UDF call render the result as a String
4 participants
@jmao-denver @chipkent @rcaudy @cpwright