Enable build parallelism by default. #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also paves the way for larger CI runner support.
devinrsmith
added
build
ci
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
requested review from
jcferretti,
JamesXNelson,
mofojed and
rcaudy
as code owners
devinrsmith
commented
Jun 21, 2023
Comment on lines
-48
to
-50
| if (!maxParallelForks) { | ||
| maxParallelForks = 4 | ||
| } |
There was a problem hiding this comment.
This logic never worked; the inner code is never executed.
rcaudy
reviewed
Jun 21, 2023
jcferretti
reviewed
Jun 21, 2023
jcferretti
reviewed
Jun 21, 2023
.github/workflows/build-ci.yml
Outdated
| @@ -32,6 +32,8 @@ jobs: | |||
| run: | | |||
| cat .github/env/${{ runner.os }}/gradle.properties >> gradle.properties | |||
| echo >> gradle.properties | |||
| .github/scripts/print-gradle-workers-max.sh >> gradle.properties | |||
| echo >> gradle.properties | |||
There was a problem hiding this comment.
The block below is almost the same. Too hard to factor the common parts out?
There was a problem hiding this comment.
I've taken your advice and consolidated it down to a single script.
jcferretti
previously approved these changes
Jun 21, 2023
jcferretti
approved these changes
Jun 22, 2023
mofojed
approved these changes
Jun 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also paves the way for larger CI runner support.
Note: I've been running w/
org.gradle.parallel=truefor at least a year without ill-effect. I think some other developers have been as well.