Improve the error check/message in array() #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
NoDocumentationNeeded
python-server-side
NoReleaseNotesNeeded
rcaudy
approved these changes
Jul 13, 2023
| @@ -202,6 +202,9 @@ def array(dtype: DType, seq: Sequence, remap: Callable[[Any], Any] = None) -> jp | |||
| Raises: | |||
| DHError | |||
| """ | |||
| if not isinstance(dtype, DType): | |||
There was a problem hiding this comment.
Wait, we really need to do this? Python will let you just pass any type you want?
There was a problem hiding this comment.
yeah, that's Python, the idiomatic approach is to not check the type of the argument but maybe the value, but we have a problem with the raise statement in the try/except block that intends to provide the Java class name in the message:
except Exception as e: raise DHError(e, f"failed to create a Java {dtype.j_name} array.") from e
jjbrosnan
approved these changes
Jul 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4167