Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port of DH-13185: fix FunctionalColumn #4235

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Port of DH-13185: fix FunctionalColumn #4235

merged 2 commits into from
Jul 27, 2023

Conversation

devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Jul 26, 2023 •
edited
Loading

fillPrevChunk was looking at current instead of previous

@devinrsmith devinrsmith changed the title Port of DH-13185: FunctionalColumn fillPrevChunk was looking at curre… Port of DH-13185: fix FunctionalColumn Jul 26, 2023
@devinrsmith devinrsmith requested a review from rcaudy July 26, 2023 22:57
@devinrsmith devinrsmith self-assigned this Jul 26, 2023
@devinrsmith devinrsmith added this to the July 2023 milestone Jul 26, 2023
@devinrsmith devinrsmith added bug Something isn't working NoReleaseNotesNeeded No release notes are needed. NoDocumentationNeeded labels Jul 26, 2023
rcaudy
rcaudy reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except the failing test. We need to control source satisfaction. 909e74a from my fork will fix it.

@devinrsmith devinrsmith marked this pull request as ready for review July 27, 2023 03:47
@devinrsmith devinrsmith requested a review from rcaudy July 27, 2023 03:47
@devinrsmith devinrsmith merged commit 73ad776 into deephaven:main Jul 27, 2023
10 checks passed
@devinrsmith devinrsmith deleted the fix-FunctionalColumn branch July 27, 2023 05:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees

@devinrsmith devinrsmith

Labels
bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
July 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@devinrsmith @rcaudy