R Client 2.0 - Table Ops #4240
Merged
R Client 2.0 - Table Ops #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # R/rdeephaven/src/client.cpp
…pose relevant functions via roxygen tags
…AMESPACE this time
chipkent
requested changes
Aug 14, 2023
chipkent
requested changes
Aug 14, 2023
chipkent
requested changes
Aug 14, 2023
chipkent
requested changes
Aug 14, 2023
chipkent
requested changes
Aug 15, 2023
chipkent
requested changes
Aug 15, 2023
chipkent
requested changes
Aug 15, 2023
alexpeters1208
force-pushed
the
api-expansion
branch
from
3ee527a
to
794ef84
Compare
chipkent
approved these changes
Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new table operations to the R client, presented in a
dplyrlike syntax that will feel familiar to R users. The best places to see the comparison between the new table operations and what "native R" would look and feel like is in theinst/tests/testthat/test_table_ops.Randinst/tests/testthat/test_agg_by.Rfiles. These unit tests are approached as solving the same problem indplyrwithtibbles and the new R client table operations, ensuring correctness while also providing a kind of translation manual.The documentation of the
table_ops.Ris not hooked in yet, and there is discussion to be had over the names of some of our operations, as they are consistent with the other Deephaven clients but conflict with function names that already exist in R. This is an easily solvable problem, but it is worth discussing whether we want to mask common functions.This PR also adds a
closemethod to the client, and it is encouraged to call this method when the client connection is no longer needed.Resolves #256
Resolves #4090