Correctly read nulls in int96 based timestamps in Parquet #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
bug
malhotrashivam
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
rbasralian
reviewed
Aug 1, 2023
.../table/src/main/java/io/deephaven/parquet/table/pagestore/topage/ToInstantPageFromInt96.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Aug 1, 2023
.../table/src/main/java/io/deephaven/parquet/table/pagestore/topage/ToInstantPageFromInt96.java
Outdated
Show resolved
Hide resolved
jcferretti
reviewed
Aug 1, 2023
.../table/src/main/java/io/deephaven/parquet/table/pagestore/topage/ToInstantPageFromInt96.java
Outdated
Show resolved
Hide resolved
jcferretti
previously approved these changes
Aug 1, 2023
jcferretti
approved these changes
Aug 1, 2023
rcaudy
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix, closes #4250
As mentioned in the bug report, the existing code throws a NullPointerException while accessing null values in timestamps represented as int96. This works correctly though for Instant represented as int64, which is the default. This PR fixes the same.