Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For docker runs (tests) ensure we get results even when the run (test) fails. #4254

Merged
merged 5 commits into from
Aug 2, 2023
Merged

For docker runs (tests) ensure we get results even when the run (test) fails. #4254

merged 5 commits into from
Aug 2, 2023

Conversation

jcferretti
Copy link
Member

No description provided.

@jcferretti jcferretti added this to the August 2023 milestone Aug 1, 2023
@jcferretti jcferretti self-assigned this Aug 1, 2023
jmao-denver
jmao-denver previously approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

niloc132
niloc132 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the reports are copied out both when tests are successful and when they fail.

Verified that the web-client-ui:ui task and others correctly are still marked as up-to-date, and don't need to re-run when there are no changes to their inputs.

@jcferretti jcferretti enabled auto-merge (squash) August 2, 2023 19:34
@jmao-denver jmao-denver self-requested a review August 2, 2023 19:35
@jcferretti jcferretti merged commit 51b88b3 into deephaven:main Aug 2, 2023
9 checks passed
@jcferretti jcferretti deleted the cfs-docker-fail-sync-still-copy branch August 2, 2023 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niloc132 niloc132 niloc132 approved these changes

@jmao-denver jmao-denver jmao-denver approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jcferretti jcferretti

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@jcferretti @niloc132 @jmao-denver