Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failure in reading lists in parquet files #4275

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

malhotrashivam
Copy link
Contributor

@malhotrashivam malhotrashivam commented Aug 4, 2023

Bug fix, closes #4270

Some of the variables were not being properly initialized in the code for reading lists. This PR fixes the bug and includes refactoring to improve the code quality.

@malhotrashivam malhotrashivam added bug Something isn't working parquet Related to the Parquet integration NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Aug 4, 2023
@malhotrashivam malhotrashivam added this to the August 2023 milestone Aug 4, 2023
@malhotrashivam malhotrashivam self-assigned this Aug 4, 2023
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a very good solution. Please let me know when you've tested and I can approve it.

@malhotrashivam malhotrashivam enabled auto-merge (squash) August 6, 2023 16:49
@malhotrashivam malhotrashivam changed the title (WIP) Fix for failure in reading lists Fix for failure in reading lists Aug 6, 2023
@malhotrashivam malhotrashivam changed the title Fix for failure in reading lists Fix for failure in reading lists in parquet files Aug 6, 2023
@malhotrashivam malhotrashivam merged commit 92d7835 into deephaven:main Aug 7, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. parquet Related to the Parquet integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column with list in parquet file can not be displayed and gives error in ide
2 participants