MultiJoin - correct bug when multiple columns are supplied #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbooker42
added
NoDocumentationNeeded
NoReleaseNotesNeeded
rcaudy
reviewed
Aug 7, 2023
Comment on lines
771
to
772
| MultiJoinInput.of(t1, "Key1=A,Key2=B", "C1=C,D1=D"), | ||
| MultiJoinInput.of(t2, "Key1=A,Key2=B", "C2=C,D2=D")); |
There was a problem hiding this comment.
Please add cases with spaces around the column names, and "==". I believe JoinAddition.parse, JoinMatch.parse, and ColumnName.parse address these, but it would be best to verify.
There was a problem hiding this comment.
Also, we can pretty much just verify that we got the expected multi join input. No need to run an actual MJ for all test cases of MJI.
There was a problem hiding this comment.
I did test these manually because I was also curious but I will formalize into a test. Good point about the MJI, can be much simpler.
rcaudy
approved these changes
Aug 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing support for parsing multiple columns in the
MultijoinInputcreation for aMultiJointable.Addresses #4276.