Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cummax consistent with cummin #4343

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Make cummax consistent with cummin #4343

merged 3 commits into from
Sep 1, 2023

Conversation

chipkent
Copy link
Member

Make cummax consistent with cummin. cummax did not handle nulls properly.

@chipkent chipkent added bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Aug 18, 2023
@chipkent chipkent added this to the August 2023 milestone Aug 18, 2023
@chipkent chipkent self-assigned this Aug 18, 2023
@chipkent chipkent marked this pull request as ready for review August 21, 2023 17:46
kosak
kosak reviewed Sep 1, 2023
View reviewed changes
engine/function/src/templates/Numeric.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Numeric.ftl Outdated Show resolved Hide resolved
@chipkent chipkent enabled auto-merge (squash) September 1, 2023 20:00
@chipkent chipkent merged commit c926780 into deephaven:main Sep 1, 2023
10 checks passed
@chipkent chipkent deleted the cummin_cummax branch September 1, 2023 20:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kosak kosak kosak approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

@lbooker42 lbooker42 Awaiting requested review from lbooker42

Assignees

@chipkent chipkent

Labels
bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@chipkent @kosak