Move the C++ client to shared libraries; reorganize its dir structure. #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcferretti
added
NoDocumentationNeeded
NoReleaseNotesNeeded
jcferretti
requested review from
chipkent,
alexpeters1208,
rcaudy and
devinrsmith
as code owners
kosak
previously approved these changes
Aug 19, 2023
kosak
previously approved these changes
Aug 20, 2023
kosak
previously approved these changes
Aug 20, 2023
chipkent
requested changes
Aug 21, 2023
devinrsmith
previously approved these changes
Aug 21, 2023
jcferretti
dismissed stale reviews from devinrsmith, alexpeters1208, and kosak
via
349ca64
devinrsmith
previously approved these changes
Aug 21, 2023
kosak
previously approved these changes
Aug 21, 2023
chipkent
approved these changes
Aug 21, 2023
devinrsmith
approved these changes
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes updating the cpp base docker image for the corresponding version that knows how to build
shared libraries for the dependencies (eg, gRPC and friends).
The
libclientlibrary was renamed tolibdhclient, as "client" on its own seemed too potentially ambiguous in the context of resolving shared library names (this is the one change that impacted the R client in this diff)