Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to ingest Kafka String columns in Avro Utf8 format #4352

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Option to ingest Kafka String columns in Avro Utf8 format #4352

merged 7 commits into from
Aug 22, 2023

Conversation

devonpallison
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@devinrsmith devinrsmith self-requested a review August 21, 2023 21:54
@devinrsmith devinrsmith added the feature request New feature or request label Aug 21, 2023
@devinrsmith devinrsmith added this to the August 2023 milestone Aug 21, 2023
@devonpallison
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

devinrsmith
devinrsmith requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In favor of this change, seems good. Couple of finishing points need to be addressed first.

.github/workflows/cla.yml Outdated Show resolved Hide resolved
extensions/kafka/src/main/java/io/deephaven/kafka/AvroImpl.java Outdated Show resolved Hide resolved
extensions/kafka/src/main/java/io/deephaven/kafka/AvroImpl.java Outdated Show resolved Hide resolved
extensions/kafka/src/main/java/io/deephaven/kafka/AvroImpl.java Outdated Show resolved Hide resolved
@devinrsmith
Copy link
Member

recheck

devinrsmith
devinrsmith reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this provide DHE w/ enough hooks to actually use utf8?

I see KafkaTools.avroSchemaToColumnDefinitions, but no tie-ins w/ KafkaTools.avroSpec. Even though you've added io.deephaven.kafka.AvroImpl.AvroConsume#useUTF8Strings, that's a package private class, not publicly visible.

@devonpallison
Copy link
Contributor Author

Does this provide DHE w/ enough hooks to actually use utf8?

I see KafkaTools.avroSchemaToColumnDefinitions, but no tie-ins w/ KafkaTools.avroSpec. Even though you've added io.deephaven.kafka.AvroImpl.AvroConsume#useUTF8Strings, that's a package private class, not publicly visible.

This should be fixed. I was fooled by groovy ignoring the package protection when I was testing this

@devinrsmith devinrsmith merged commit df3740e into deephaven:main Aug 22, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinrsmith devinrsmith devinrsmith approved these changes

@jcferretti jcferretti Awaiting requested review from jcferretti

@JamesXNelson JamesXNelson Awaiting requested review from JamesXNelson

@mofojed mofojed Awaiting requested review from mofojed

@rcaudy rcaudy Awaiting requested review from rcaudy

Assignees

@devonpallison devonpallison

Labels
feature request New feature or request NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@devonpallison @devinrsmith