Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition to python using native python time types instead of Java types #4388

Merged
merged 43 commits into from
Sep 1, 2023
Merged

Transition to python using native python time types instead of Java types #4388

merged 43 commits into from
Sep 1, 2023

Conversation

chipkent
Copy link
Member

@chipkent chipkent commented Aug 28, 2023 •
edited by jmao-denver
Loading

Transition from using Java time types in python to using python time types in python.

Fixes #4214

@chipkent chipkent self-assigned this Aug 28, 2023
jjbrosnan
jjbrosnan reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@jjbrosnan jjbrosnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, some small stuff.

jmao-denver
jmao-denver reviewed Aug 31, 2023
View reviewed changes
py/server/deephaven/time.py Outdated Show resolved Hide resolved
py/server/deephaven/time.py Outdated Show resolved Hide resolved
py/server/tests/test_pandas.py Outdated Show resolved Hide resolved
py/server/tests/test_table.py Outdated Show resolved Hide resolved
py/server/tests/test_numpy.py Outdated Show resolved Hide resolved
py/server/deephaven/time.py Show resolved Hide resolved
jmao-denver
jmao-denver previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmao-denver
jmao-denver previously approved these changes Aug 31, 2023
View reviewed changes
cpwright
cpwright reviewed Aug 31, 2023
View reviewed changes
py/server/deephaven/table_factory.py Outdated Show resolved Hide resolved
py/server/deephaven/table_factory.py Outdated Show resolved Hide resolved
py/server/deephaven/time.py Outdated Show resolved Hide resolved
py/server/tests/test_arrow.py Outdated Show resolved Hide resolved
py/server/tests/test_numpy.py Outdated Show resolved Hide resolved
py/server/tests/test_pandas.py Outdated Show resolved Hide resolved
jmao-denver
jmao-denver reviewed Sep 1, 2023
View reviewed changes
py/server/deephaven/time.py
Comment on lines +68 to +69
except TypeError as e:
raise e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, could be a bit simpler:

except TypeError:
    raise

jmao-denver
jmao-denver approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chipkent chipkent merged commit 7a6060a into deephaven:main Sep 1, 2023
10 checks passed
@chipkent chipkent deleted the native_py_time branch September 1, 2023 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/3123
Reference: https://github.com/deephaven/deephaven.io/issues/3124

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpwright cpwright cpwright left review comments

@jjbrosnan jjbrosnan jjbrosnan left review comments

@jmao-denver jmao-denver jmao-denver approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

@devinrsmith devinrsmith Awaiting requested review from devinrsmith

@alexpeters1208 alexpeters1208 Awaiting requested review from alexpeters1208

Assignees

@chipkent chipkent

Labels
breaking DocumentationNeeded python python-server-side ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decommission time.py from the server Python API
7 participants
@chipkent @deephaven-internal @jmao-denver @devinrsmith @cpwright @alexpeters1208 @jjbrosnan